information/core_il_data_object_model.xsl : mapping protege instance identifiers to json : dubious calls to translate
Posted: 18 Apr 2019, 12:05
Hi,
I found dubious calls to 'fn:translate' in information/core_il_data_object_model.xsl. It seems that the author intend was to use "point json expression" to access the value of slots in json e.g (in pseudo code) :
instead of the more universal "map json expression"
.
Obviously the first expression (point json) has some stringent syntax restrictions : nor special characters nor dot ('.') point character should occurs in the identifier while the second expression ('map json ') has no such restriction .... hence the calls to translate.
IMHO these calls to translate should be replaced (or else you could use the xslt 3.0 xml-to-json translation
Regards,
Jean-Marie.
Ps: I'm not sure that my English is good enough to make me clear
so you mail have a look at the diff here :
https://github.com/essentialproject/ess ... 62dbdbbf03
I found dubious calls to 'fn:translate' in information/core_il_data_object_model.xsl. It seems that the author intend was to use "point json expression" to access the value of slots in json e.g (in pseudo code) :
Code: Select all
dataObject.translation-in-json-point-notation-of (instance/name) ...
Code: Select all
dataObject['instance/name'] ...
Obviously the first expression (point json) has some stringent syntax restrictions : nor special characters nor dot ('.') point character should occurs in the identifier while the second expression ('map json ') has no such restriction .... hence the calls to translate.
IMHO these calls to translate should be replaced (or else you could use the xslt 3.0 xml-to-json translation
Regards,
Jean-Marie.
Ps: I'm not sure that my English is good enough to make me clear
so you mail have a look at the diff here :https://github.com/essentialproject/ess ... 62dbdbbf03